-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shared-data): add custom & default thermocycler overlap offsets for labware #13630
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.0.1 #13630 +/- ##
====================================================
Coverage 71.25% 71.25%
====================================================
Files 2429 2429
Lines 68405 68405
Branches 8033 8033
====================================================
Hits 48740 48740
Misses 17769 17769
Partials 1896 1896
Flags with carried forward coverage won't be shown. Click here to find out more.
|
🙌 Thanks for the thorough testing! @SyntaxColoring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI passes—does this need updates to G-code tests?
Not sure. Checking now. Did we resolve the g-code test failure issues on the release branch? The PD & Labware library tests are failing on all PRs because of some CI chrome version issue so going to ignore those failures. |
Yes, as far as I know.
👍 Yep. #13705 (review) |
…for labware (#13630) * added TC overlaps for nest & biorad pcr plates * added a backwards-compatible default overlap for TC labware on OT2 * fix pd e2e migration fixture --------- Co-authored-by: Jethary <[email protected]>
…for labware (#13630) * added TC overlaps for nest & biorad pcr plates * added a backwards-compatible default overlap for TC labware on OT2 * fix pd e2e migration fixture --------- Co-authored-by: Jethary <[email protected]>
…for labware (#13630) (#13750) * added TC overlaps for nest & biorad pcr plates * added a backwards-compatible default overlap for TC labware on OT2 * fix pd e2e migration fixture --------- Co-authored-by: Sanniti Pimpley <[email protected]>
Overview
Closes RSS-353
stackingOverlapWithModule
for Biorad & NEST PCR plates on TC Gen2.Test Plan
The ticket above has a protocol attached for testing. That protocol places a nest PCR plate, a biorad plate and a custom pcr plate on the thermocycler one ofter the other to check for location precision. You will need to create and upload a custom PCR plate definition as mentioned in the protocol.
Upload this protocol to a Flex and check that:
Adjust the protocol for running on OT2 and upload to an OT2:
Changelog
state.labware. get_module_overlap_offsets()
Review requests
Risk assessment
Low. Just adds the missing overlap values. Low risk if tests show expected results.